Closed jerolimov closed 1 month ago
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284
!
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284
!
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284
!
/cc @debsmita1 @divyanshiGupta @ciiay @karthikjeeyar /assign
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284
!
/retest
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284
!
tested it locally /lgtm
/lgtm cancel Wanted to add the label to the PR on the backstage-plugins repo
Hi @jerolimov , only one standing out alignment issue. I have left a comment in the theme repo commits of the cause of this.
Another thing is about the software template card size. It misses some setting and the old issue will exist again. Here's the comment I left for the cause of this issue in theme repo. The rest looks great to me. Thank you.
looks good to me @jerolimov, thank you to everyone who has been involved
/approve
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code
Hi @jerolimov , only one standing out alignment issue. I have left a comment in the theme repo commits of the cause of this.
Hi @ciiay, thanks for the review.
I fixed this in the showcase repo with my 2nd PR. For me, it looks now like this:
Another thing is about the software template card size. It misses some setting and the old issue will exist again. Here's the comment I left for the cause of this issue in theme repo. The rest looks great to me. Thank you.
As we discussed, I restored your old PR and it looks now like this (with manually added more text):
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284
!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ciiay, invincibleJai
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/retest
/retest
/override images e2e-tests
@jerolimov: jerolimov unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.
/override ci/prow/images /override ci/prow/e2e-tests
@nickboldt: Overrode contexts on behalf of nickboldt: ci/prow/e2e-tests, ci/prow/images
This PR updates the theme to the latest version, which includes improvements and bugfixes. Esp. this changes:
Here are some screenshots to compare some of these changes:
Light
Dark