janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
103 stars 139 forks source link

chore(deps): update RHDH theme #1284

Closed jerolimov closed 1 month ago

jerolimov commented 1 month ago

This PR updates the theme to the latest version, which includes improvements and bugfixes. Esp. this changes:

  1. The Red Hat font is now also part of the package and used for text, headlines and code blocks.
  2. The headline font sized are a bit more aligned with PF
  3. Removed underlines from the main navigation
  4. Tab and content is more alignment on the settings page
  5. Padding between cards on the home page is more aligned, for this I removed some special rules that works not well with all card sizes
  6. Cards border color like PF6 (as Christophe requested today)
  7. Added the 1px line below the header (as Christophe requested today) -- But it's also shown when when the tabs appear, so hmm..
  8. Removed "always uppercase" from ToggleButtons (as we had this already for Buttons, for example on the settings page when selecting a theme)

Here are some screenshots to compare some of these changes:

Light

Backstage Old theme New theme
3-catalog-backstage-light 3-catalog-rhdh-light 3-catalog-rhdh-light
4-catalog-entry-backstage-light 4-catalog-entry-rhdh-light 4-catalog-entry-rhdh-light
8-settings-backstage-light 8-settings-rhdh-light 8-settings-rhdh-light

Dark

Backstage Old theme New theme
3-catalog-backstage-dark 3-catalog-rhdh-dark 3-catalog-rhdh-dark
4-catalog-entry-backstage-dark 4-catalog-entry-rhdh-dark 4-catalog-entry-rhdh-dark
8-settings-backstage-dark 8-settings-rhdh-dark 8-settings-rhdh-dark
github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284!

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284!

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284!

jerolimov commented 1 month ago

/cc @debsmita1 @divyanshiGupta @ciiay @karthikjeeyar /assign

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284!

jerolimov commented 1 month ago

/retest

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284!

debsmita1 commented 1 month ago

tested it locally /lgtm

debsmita1 commented 1 month ago

/lgtm cancel Wanted to add the label to the PR on the backstage-plugins repo

ciiay commented 1 month ago

Hi @jerolimov , only one standing out alignment issue. I have left a comment in the theme repo commits of the cause of this.

image

Another thing is about the software template card size. It misses some setting and the old issue will exist again. Here's the comment I left for the cause of this issue in theme repo. The rest looks great to me. Thank you.

ShiranHi commented 1 month ago

looks good to me @jerolimov, thank you to everyone who has been involved

invincibleJai commented 1 month ago

/approve

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

jerolimov commented 1 month ago

Hi @jerolimov , only one standing out alignment issue. I have left a comment in the theme repo commits of the cause of this.

Hi @ciiay, thanks for the review.

I fixed this in the showcase repo with my 2nd PR. For me, it looks now like this:

image

Another thing is about the software template card size. It misses some setting and the old issue will exist again. Here's the comment I left for the cause of this issue in theme repo. The rest looks great to me. Thank you.

As we discussed, I restored your old PR and it looks now like this (with manually added more text):

image

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1284!

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciiay, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [invincibleJai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jerolimov commented 1 month ago

/retest

jerolimov commented 1 month ago

/retest

jerolimov commented 1 month ago

/retest

jerolimov commented 1 month ago

/override images e2e-tests

openshift-ci[bot] commented 1 month ago

@jerolimov: jerolimov unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to [this](https://github.com/janus-idp/backstage-showcase/pull/1284#issuecomment-2146253214): >/override images e2e-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nickboldt commented 1 month ago

/override ci/prow/images /override ci/prow/e2e-tests

image

openshift-ci[bot] commented 1 month ago

@nickboldt: Overrode contexts on behalf of nickboldt: ci/prow/e2e-tests, ci/prow/images

In response to [this](https://github.com/janus-idp/backstage-showcase/pull/1284#issuecomment-2146257978): >/override ci/prow/images >/override ci/prow/e2e-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.