search

janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
103 stars 139 forks source link

chore: adding options to keep legacy behavior in export-dynamic script #1285

Closed jesuino closed 1 month ago

jesuino commented 1 month ago

Description

This is a fix for RHIDP-2110 and RHIDP-2123

Related PR: https://github.com/janus-idp/backstage-plugins/pull/1729

Please explain the changes you made here.

Adding the option --no-embed-as-dependencies for backend plugins and --in-place for frontend plugins.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

How to test changes / Special notes to the reviewer

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1285!

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [davidfestal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment