janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
103 stars 139 forks source link

feat(app) RHIDP-2338 expose dynamic UI config #1290

Closed gashcrumb closed 1 month ago

gashcrumb commented 1 month ago

Please explain the changes you made here.

This change exposes the dynamic UI configuration to dynamic plugins via the scalprum API holder available with the scalprum React API. This change also moves around some blocks for consistency and improves the typing for the DynamicRootContext objects.

PR acceptance criteria

Please make sure that the following steps are complete:

How to test changes / Special notes to the reviewer

This can be validated using this plugin which contains a component that will use the configuration exposed via scalprum to create a new mount point, and then render a component on that mount point. Use this configuration:

    backstage-plugin-simple-test-components:
      dynamicRoutes:
        - path: /test-route
          importName: CustomSearchPage
          menuItem:
            text: Search2
      mountPoints:
        - mountPoint: custom.mount.point
          importName: SimpleTestComponentsPage
          config:
            props:
              text: 'Content Block in a custom mount point'
github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1290!

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1290!

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1290!

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

gashcrumb commented 1 month ago

/retest

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1290!

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [davidfestal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidfestal commented 1 month ago

/retest

davidfestal commented 1 month ago

/retest

gashcrumb commented 1 month ago

seems to be some infra flakiness, or I wonder if the test config has an issue

davidfestal commented 1 month ago

/retest

davidfestal commented 1 month ago

/retest

davidfestal commented 1 month ago

/test images

davidfestal commented 1 month ago

/test images

gashcrumb commented 1 month ago

/retest

davidfestal commented 1 month ago

/test images

jerolimov commented 1 month ago

/retest

davidfestal commented 1 month ago

/test e2e-tests

davidfestal commented 1 month ago

/cherry-pick 1.2.x

openshift-cherrypick-robot commented 1 month ago

@davidfestal: new pull request created: #1302

In response to [this](https://github.com/janus-idp/backstage-showcase/pull/1290#issuecomment-2149134364): >/cherry-pick 1.2.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.