search

janus-idp / backstage-showcase

This repo is moving to https://github.com/redhat-developer/red-hat-developer-hub
https://showcase.janus-idp.io
Apache License 2.0
110 stars 143 forks source link

feat: support catalog entity extra context menu items. #1298

Closed davidfestal closed 4 months ago

davidfestal commented 4 months ago

Description

This PR adds support for dynamic frontend plugins that contribute extra items in the Catalog entity package content menu.

Without this support, plugins like the upstream badges or playlist plugins cannot be used as dynamic plugins.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

How to test changes / Special notes to the reviewer

github-actions[bot] commented 4 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1298!

github-actions[bot] commented 4 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1298!

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [gashcrumb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
github-actions[bot] commented 4 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1298!

gashcrumb commented 4 months ago

/retest

nickboldt commented 4 months ago

/cherry-pick 1.2.x

openshift-cherrypick-robot commented 4 months ago

@nickboldt: new pull request created: #1300

In response to [this](https://github.com/janus-idp/backstage-showcase/pull/1298#issuecomment-2148092620): >/cherry-pick 1.2.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.