Closed rm3l closed 1 week ago
@rm3l: This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue
command.
The relevant updates have been made for this issue and I have also opened up the PR: https://github.com/janus-idp/backstage-showcase/pull/1332.
Fixed by https://github.com/janus-idp/backstage-showcase/pull/1332
/close
@rm3l: Closing this issue.
What do you want to improve?
https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/monitoring-and-logging.md#operator-backed-deployment
Stumbled upon this while reviewing https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/263
What is the current documentation?
In the
ServiceMonitor
resource to create, the label name added by the Operator has changed fromjanus-idp.io/app
torhdh.redhat.com/app
a long time ago (https://github.com/janus-idp/operator/issues/199) before the first version of the operator was released, and we forgot to update this doc.Also, the container port endpoint to scrape metrics from seems to be wrong. It should be
backend
as per the1.1.x
,1.2.x
ormain
branches in the operator repo.As a consequence, the instructions depicted in this https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/monitoring-and-logging.md#operator-backed-deployment will not work as expected.
What is the new documentation?
janus-idp.io/app
withrhdh.redhat.com/app
http-backend
tobackend
/good-first-issue
JIRA: https://issues.redhat.com/browse/RHIDP-2657