search

janus-idp / backstage-showcase

This repo is moving to https://github.com/redhat-developer/red-hat-developer-hub
https://janus-idp.io
Apache License 2.0
113 stars 151 forks source link

ArgoCD Overview and History Cards render when argocd annotation doesn't exist #650

Closed Zaperex closed 1 year ago

Zaperex commented 1 year ago

Describe the bug

ArgoCD Overview Card (in Overview tab) and ArgoCD History Card (in CD tab) appear even when the argocd annotations don't exist in the catalog-info.yaml of the component. image image

Expected Behavior

The ArgoCD Overview and History Cards (Since CD tab is just the history card, it shouldn't appear either) should conditionally render depending on whether the argocd annotation exists for the component image

What are the steps to reproduce this bug?

  1. Have a component entity registered into the catalog
  2. Make sure component has no argocd annotations, and has spec.type as either website or service
  3. Observe Missing Annotation error cards in place of argocd overview and history card
Zaperex commented 1 year ago

Solved by https://github.com/janus-idp/backstage-showcase/pull/700