Ran through the README to do a deployment. Noticed a few things that were confusing or missing. And a couple minor best practices that I cleaned up. Have not run through the other READMEs yet.
Change companyname to camel case which is recommended by helm
Created a generic values folder that we can use for example values in the README. This way we can clean up our actually value.yaml files to be more aimed toward the final users and have a totally separate set of values files aimed toward demoing/quickstarts. (Also just a heads up you don't have to specify -f values.yaml if the values.yaml file lives in the chart directory)
Moved app-config.yaml into it's own file. I just find that makes both the config file and the template easier to read.
Fixed y'alls postgres secret logic so the secret won't change on upgrades. Everything was right you guys where just grabbing the wrong secret. And updated the README so it no longer has the work around. But as I noted in the comment this won't work on Argo because lookup functions down work on Argo.
PR Breakdown:
Did a couple things in this PR.
Ran through the README to do a deployment. Noticed a few things that were confusing or missing. And a couple minor best practices that I cleaned up. Have not run through the other READMEs yet.
Change
companynameto camel case which is recommended by helmCreated a generic
valuesfolder that we can use for example values in the README. This way we can clean up our actuallyvalue.yamlfiles to be more aimed toward the final users and have a totally separate set of values files aimed toward demoing/quickstarts. (Also just a heads up you don't have to specify-f values.yamlif the values.yaml file lives in the chart directory)Moved
app-config.yamlinto it's own file. I just find that makes both the config file and the template easier to read.Fixed y'alls postgres secret logic so the secret won't change on upgrades. Everything was right you guys where just grabbing the wrong secret. And updated the README so it no longer has the work around. But as I noted in the comment this won't work on Argo because
lookupfunctions down work on Argo.