search

janus-idp / demo-setup

Apache License 2.0
9 stars 23 forks source link

generic OPENSHIFT_CLUSTER_INFO url detection #80

Closed ryanj closed 1 year ago

ryanj commented 1 year ago

Add support for ROSA clusters, and clusters that do not include "cluster-" in the cluster url

mattheh commented 1 year ago

The reference in /docs/docs/install/index.md should be updated too, that's what will get deployed to our GH pages. Aside from that looks good

If you find and replace all instances of $(oc cluster-info | grep -Eo '.cluster(.*?).com') and replace it with that you have, that would be good too, your way is more versatile

ryanj commented 1 year ago

Thanks for the feedback. I've added the change in /docs/docs/install/index.md and README.md as well.

I have the remaining config string updates in my local copy of /values/rhsso.yaml, but I can't commit them because of a .gitignore rule. Any advice on how to proceed?

ryanj commented 1 year ago

Thanks! I think I figured out how to ignore the .gitignore rule

I believe the changes are all there for deployment to ROSA