[API] Move runtime objects related configuration out of spec.Application

gazarenkov commented 8 months ago

By idea, spec.Application section is for configuration Backstage Application container (app-configs, extra files, env vars...) and it is quite confusing to see configuration of workload k8s objects (such as replicas, network, image etc) here as well.

Proposal is to:

move backstage runtime configuration (image, replicas, image-pull secrets) on top level
move route to new Network section

So CR.spec would look like this:

spec:
  image: my-img
  imagePullSecrets: []
  replicas: 2
  application:
    appConfig: {}
    extraFiles: {}
    extraEnvs: {}
    dynamicPluginsConfigMapName: my-dp-cm
  database:
    enableLocalDb: true
  network:
   route: {}

gazarenkov commented 3 months ago

can be closed along with: https://github.com/janus-idp/operator/issues/352

nickboldt commented 2 months ago

As part of the migration from janus-idp to redhat-developer in https://issues.redhat.com/browse/RHIDP-1021, this will be tracked in https://issues.redhat.com/browse/RHIDP-1138

janus-idp / operator

[API] Move runtime objects related configuration out of spec.Application #178