janus-idp / operator

Deprecated - Operator for Backstage, based on the Operator SDK framework - see https://github.com/redhat-developer/rhdh-operator
https://github.com/redhat-developer/rhdh-operator
Apache License 2.0
15 stars 15 forks source link

add resources.requests to default config #347

Closed gazarenkov closed 7 months ago

gazarenkov commented 7 months ago

Description

add resources.requests to default config

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-2159

PR acceptance criteria

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from gazarenkov. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/janus-idp/operator/blob/1.1.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot] commented 7 months ago

PR images are available:

  1. https://quay.io/janus-idp/operator:0.1.2-pr-347-c03dc53
  2. https://quay.io/janus-idp/operator-bundle:0.1.2-pr-347-c03dc53
  3. https://quay.io/janus-idp/operator-catalog:0.1.2-pr-347-c03dc53

gazarenkov commented 7 months ago

Please apply these changes in the .rhdh folder too, and comment on this PR or the JIRA, to let me know if this needs to be fixed in main branch as well.

Please let me know what exactly to change. Unless I missed something there are no changes in .rhdh's CSV? it should come with:

              volumes:
              - configMap:
                  name: backstage-default-config
                name: default-config

No needs to fix in main, it should be already there.

nickboldt commented 7 months ago

oops, sorry -- I saw a change to configmap and a timestamp in the CSV and misread that as real changes to the CSV. Not sure why you updated the timestamp if nothing was changed in the CSV, but it's cool, I can merge this.