Closed gazarenkov closed 7 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from gazarenkov. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Please apply these changes in the .rhdh folder too, and comment on this PR or the JIRA, to let me know if this needs to be fixed in main branch as well.
Please let me know what exactly to change. Unless I missed something there are no changes in .rhdh's CSV? it should come with:
volumes:
- configMap:
name: backstage-default-config
name: default-config
No needs to fix in main, it should be already there.
oops, sorry -- I saw a change to configmap and a timestamp in the CSV and misread that as real changes to the CSV. Not sure why you updated the timestamp if nothing was changed in the CSV, but it's cool, I can merge this.
Description
add resources.requests to default config
Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHIDP-2159
PR acceptance criteria