search

janus-idp / operator

Deprecated - Operator for Backstage, based on the Operator SDK framework - see https://github.com/redhat-developer/rhdh-operator
https://github.com/redhat-developer/rhdh-operator
Apache License 2.0
15 stars 15 forks source link

Fix the RBAC permissions of the Operator in the RHDH CSV #361

Closed rm3l closed 6 months ago

rm3l commented 6 months ago

Description

There was a difference in the RBAC permissions of the operator between the CSV used for RHDH (https://github.com/janus-idp/operator/blob/main/.rhdh/bundle/manifests/rhdh-operator.csv.yaml) and the upstream one (https://github.com/janus-idp/operator/blob/main/bundle/manifests/backstage-operator.clusterserviceversion.yaml). This causes issues like the one reported in #360.

Which issue(s) does this PR fix or relate to

PR acceptance criteria

How to test changes / Special notes to the reviewer

Diff should only be about the service account name:

$ diff -U 1 \
    <(yq '.spec.install.spec.clusterPermissions' bundle/manifests/backstage-operator.clusterserviceversion.yaml) \
    <(yq '.spec.install.spec.clusterPermissions' .rhdh/bundle/manifests/rhdh-operator.csv.yaml)

--- /proc/self/fd/11    2024-05-14 16:28:32.538242718 +0200
+++ /proc/self/fd/12    2024-05-14 16:28:32.539242725 +0200
@@ -107,2 +107,2 @@
         - create
-  serviceAccountName: backstage-controller-manager
+  serviceAccountName: rhdh-operator

We can retry the repro steps depicted in https://github.com/janus-idp/operator/issues/360 after a new downstream build is done (after this PR merged).

github-actions[bot] commented 6 months ago

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-361-e4f35e5
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-361-e4f35e5
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-361-e4f35e5

github-actions[bot] commented 6 months ago

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-361-b26032b
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-361-b26032b
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-361-b26032b

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot] commented 6 months ago

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-361-c36d734
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-361-c36d734
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-361-c36d734

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gazarenkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/operator/blob/main/OWNERS)~~ [gazarenkov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment