Make a default db-service headless and use it as a serviceName for StatefulSet

gazarenkov commented 5 months ago

Description

I mostly addressed #370 as commented

db-service is converted to headless and used in SS's serviceName
SS.spec.template.metadata.name removed since it (same as generatedName) is not respected. The Pod template name is - anyway

Which issue(s) does this PR fix or relate to

https://github.com/janus-idp/operator/issues/370

PR acceptance criteria

[X] Tests

github-actions[bot] commented 5 months ago

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.
You might also need to manually update the .rhdh/bundle/manifests/rhdh-operator.csv.yaml CSV file accordingly.

github-actions[bot] commented 5 months ago

PR images are available:

github-actions[bot] commented 5 months ago

PR images are available:

github-actions[bot] commented 5 months ago

PR images are available:

gazarenkov commented 5 months ago

/cherry-pick 1.2.x

openshift-cherrypick-robot commented 5 months ago

@gazarenkov: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you.

In response to [this](https://github.com/janus-idp/operator/pull/371#issuecomment-2146893279): >/cherry-pick 1.2.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

github-actions[bot] commented 5 months ago

PR images are available:

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 5 months ago

PR images are available:

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/operator/blob/main/OWNERS)~~ [rm3l] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-cherrypick-robot commented 5 months ago

@gazarenkov: #371 failed to apply on top of branch "1.2.x":

Applying: headless service for statefulset
Applying: Regenerate bundle manifests
Applying: add test for serviceName
Using index info to reconstruct a base tree...
M   bundle/manifests/backstage-default-config_v1_configmap.yaml
M   bundle/manifests/backstage-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging bundle/manifests/backstage-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/backstage-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 add test for serviceName
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/janus-idp/operator/pull/371#issuecomment-2146893279): >/cherry-pick 1.2.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

janus-idp / operator