janus-idp / operator

Deprecated - Operator for Backstage, based on the Operator SDK framework - see https://github.com/redhat-developer/rhdh-operator
https://github.com/redhat-developer/rhdh-operator
Apache License 2.0
15 stars 15 forks source link

Fix version number in `skipRange` and `name` fields in base CSV #376

Closed rm3l closed 5 months ago

rm3l commented 5 months ago

Description

This fixes the skipRange field in the base CSV on the main branch. After rebasing https://github.com/janus-idp/operator/pull/369 onto main, I noticed a change to the generated bundle, which should not have occurred there.

Which issue(s) does this PR fix or relate to

This is a follow-up to https://github.com/janus-idp/operator/pull/375

PR acceptance criteria

How to test changes / Special notes to the reviewer

github-actions[bot] commented 5 months ago

PR images are available:

  1. https://quay.io/janus-idp/operator:0.3.0-pr-376-d37a4b5
  2. https://quay.io/janus-idp/operator-bundle:0.3.0-pr-376-d37a4b5
  3. https://quay.io/janus-idp/operator-catalog:0.3.0-pr-376-d37a4b5

rm3l commented 5 months ago

/hold

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

rm3l commented 5 months ago

It is generated file, I believe it uses kustomization.yaml

I think Kustomize picks config/manifests/bases/backstage-operator.clusterserviceversion.yaml as the base: https://github.com/janus-idp/operator/blob/main/config/manifests/kustomization.yaml#L4

So I don't think it is generated, but it serves as the base CSV used to generate the one in bundle/manifests

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gazarenkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/operator/blob/main/OWNERS)~~ [gazarenkov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
github-actions[bot] commented 5 months ago

PR images are available:

  1. https://quay.io/janus-idp/operator:0.3.0-pr-376-c407c9c
  2. https://quay.io/janus-idp/operator-bundle:0.3.0-pr-376-c407c9c
  3. https://quay.io/janus-idp/operator-catalog:0.3.0-pr-376-c407c9c