fix(examples): Fix key in ConfigMap used in example CR with `rawRuntimeConfig` [RHDHBUGS-44] - Githubissues

janus-idp / operator

Deprecated - Operator for Backstage, based on the Operator SDK framework - see https://github.com/redhat-developer/rhdh-operator

https://github.com/redhat-developer/rhdh-operator

Apache License 2.0

15 stars 15 forks source link

fix(examples): Fix key in ConfigMap used in example CR with `rawRuntimeConfig` [RHDHBUGS-44] #402

Closed rm3l closed 4 months ago

rm3l commented 4 months ago

Description

A user relied on this example to override their raw config, but the operator silently ignored it.

Which issue(s) does this PR fix or relate to

Fixes https://issues.redhat.com/browse/RHDHBUGS-44

PR acceptance criteria

[ ] Tests
[ ] Documentation
[ ] If the bundle manifests have been updated, make sure to review the rhdh-operator.csv.yaml file accordingly

How to test changes / Special notes to the reviewer

kubectl apply -f examples/postgres-secret.yaml
kubectl apply -f examples/showcase-config.yaml
kubectl apply -f examples/showcase-cr.yaml

Should work and should apply the custom config.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gazarenkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/operator/blob/main/OWNERS)~~ [gazarenkov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment