search

janus-idp / operator

Deprecated - Operator for Backstage, based on the Operator SDK framework - see https://github.com/redhat-developer/rhdh-operator
https://github.com/redhat-developer/rhdh-operator
Apache License 2.0
15 stars 15 forks source link

Rhidp 1148 add external db note #406

Closed Fortune-Ndlovu closed 4 months ago

Fortune-Ndlovu commented 4 months ago

Instead of adding a lengthy link at the end of the description paragraph, we decided to include the link as a markdown link at the end of the More Information list of markdown links. Related issue: https://issues.redhat.com/browse/RHIDP-1148?filter=-1

e

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign nickboldt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/janus-idp/operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Fortune-Ndlovu commented 4 months ago

/cherry-pick 1.2.x

openshift-cherrypick-robot commented 4 months ago

@Fortune-Ndlovu: only janus-idp org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to [this](https://github.com/janus-idp/operator/pull/406#issuecomment-2239100583): >/cherry-pick 1.2.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Fortune-Ndlovu commented 4 months ago

@Fortune-Ndlovu: only janus-idp org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

/cherry-pick 1.2.x

openshift-cherrypick-robot commented 4 months ago

@Fortune-Ndlovu: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you.

In response to [this](https://github.com/janus-idp/operator/pull/406#issuecomment-2239108360): >> @Fortune-Ndlovu: only [janus-idp](https://github.com/orgs/janus-idp/people) org members may request cherry picks. If you are already part of the org, make sure to [change](https://github.com/orgs/janus-idp/people?query=Fortune-Ndlovu) your membership to public. Otherwise you can still do the cherry-pick manually. > >/cherry-pick 1.2.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 4 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.