Closed gazarenkov closed 3 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from gazarenkov. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Failed conditions
C Security Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
PR needs rebase.
Description
In order to be able to support different types of Backstage configuration (in contrary of having Operator to RHDH/Backstage Showcase only) Kustomize scripts (./config/*) and Makefile was reworked to support 2 types of configuration:
So, now, it is possible to put PROFILE variable to related Make commands and test/run/deploy related configuration, e.g:
Which issue(s) does this PR fix or relate to
https://github.com/janus-idp/operator/issues/47 (JIRA: https://issues.redhat.com/browse/RHIDP-1338)
PR acceptance criteria
How to test changes / Special notes to the reviewer
Try to run commands with PROFILE=backstage.io and PROFILE=default (which is the same a no profile, i.e. RHDH).
NOTE: this PR is on a draft state, all the details are potential subject to change NOTE2: Mind that in contrary to RHDH, deploying bare Backstage is faster than deploying PGSQL, so usually the container run with 3rd or so attempt (DB is not accessible).