janus-idp / operator

Deprecated - Operator for Backstage, based on the Operator SDK framework - see https://github.com/redhat-developer/rhdh-operator
https://github.com/redhat-developer/rhdh-operator
Apache License 2.0
15 stars 15 forks source link

Multiple config profile #411

Closed gazarenkov closed 3 months ago

gazarenkov commented 4 months ago

Description

In order to be able to support different types of Backstage configuration (in contrary of having Operator to RHDH/Backstage Showcase only) Kustomize scripts (./config/*) and Makefile was reworked to support 2 types of configuration:

So, now, it is possible to put PROFILE variable to related Make commands and test/run/deploy related configuration, e.g:

Which issue(s) does this PR fix or relate to

https://github.com/janus-idp/operator/issues/47 (JIRA: https://issues.redhat.com/browse/RHIDP-1338)

PR acceptance criteria

How to test changes / Special notes to the reviewer

Try to run commands with PROFILE=backstage.io and PROFILE=default (which is the same a no profile, i.e. RHDH).

NOTE: this PR is on a draft state, all the details are potential subject to change NOTE2: Mind that in contrary to RHDH, deploying bare Backstage is faster than deploying PGSQL, so usually the container run with 3rd or so attempt (DB is not accessible).

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from gazarenkov. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/janus-idp/operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

openshift-merge-robot commented 4 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.