Optimize pod-refresh-on-external-config preprocessing and tests

gazarenkov commented 4 months ago

Description

This pull request:

removes check for labels/annotations on hash calculation procedure avoiding extra creation of Deployment with checksum for "empty" config and -> unexpected additional Deployment update which should fix https://issues.redhat.com/browse/RHIDP-3217 (Backstage seems have the "concurrency" problem, starting up more than one instances)
fixes config-refresh tests. Looks like newer Backstage version become more strict to the app-config content (it can not be "any" anymore)
adds retry.RetryOnConflict for better experience (retrying with no error messages in log) when add extra labels/annotations on CM/Secret

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-3217

PR acceptance criteria

[x] Tests

How to test changes / Special notes to the reviewer

Run CR with specified CM/Secrets, no extra Pod should appear on start time, no extra "CM/Secret version conflict" Log records show up
integration_tests/config-refresh_test should pass.

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 4 months ago

PR images are available:

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/operator/blob/main/OWNERS)~~ [kadel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

janus-idp / operator