janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.
Other
13 stars 8 forks source link

[REVIEW] #479 Translation for workflow state is no longer required #495

Closed lucasvanlierop closed 10 years ago

lucasvanlierop commented 10 years ago

Fixes #479

relaxnow commented 10 years ago

Why would we want to support both options? Seems like a likely source of errors and a small price to ask of user to prefix their language to the workflowstate. The config-dist even has all workflowstates translated. Or am I missing something?

lucasvanlierop commented 10 years ago

Ok I just fixed the notice but I don't really mind which solution is chosen, @pmeulen please choose how you want this to be this resolved.

lucasvanlierop commented 10 years ago

Since @pmeulen thinks this is fine for now I'll merge it. This triggered some discussion about the whole translation system not being very scalable though.