[REVIEW] #488 updatedByUser must be able to be null initially

janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.

Other

13 stars 8 forks source link

[REVIEW] #488 updatedByUser must be able to be null initially #497

Closed lucasvanlierop closed 10 years ago

lucasvanlierop commented 10 years ago

Fixes #488

thijskh commented 10 years ago

Applying just this PR does not fix #488 for me. When importing metadata I still get: Fatal error: Call to a member function getUser() on a non-object in /opt/www/OpenConext-serviceregistry/simplesamlphp/modules/janus/src/Janus/ServiceRegistry/Doctrine/Listener/AuditPropertiesUpdater.php on line 83

lucasvanlierop commented 10 years ago

Ok, then I fixed a slightly different case I ran into, I will check this again.

lucasvanlierop commented 10 years ago

@thijskh, Fixed it with a oneliner https://github.com/janus-ssp/janus/commit/7a046ae2a6c78762d70651fb0d77b086b7d1bd94) ((after quite some digging), However I recommend to fix this in a different way for the long term. (see the description in the commit)

thijskh commented 10 years ago

Fixes the problem for me. Let's merge it.