search

janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.
Other
13 stars 8 forks source link

REST API breaks on non existing connection #523

Closed lucasvanlierop closed 9 years ago

lucasvanlierop commented 9 years ago

Instead of a HTTP 404 Not Found status code a message is printed (at least in test):

Fatal error: Call to a member function getLatestRevision() on a non-object in /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/src/Janus/ServiceRegistry/Bundle/RestApiBundle/Controller/ConnectionController.php on line 108 Call Stack: 0.0001 630208 1. {main}() /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/web/app.php:0 0.0063 1191808 2. Symfony\Component\HttpKernel\Kernel->handle() /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/web/app.php:25 0.0203 2549640 3. Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel->handle() /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:187 0.0204 2550816 4. Symfony\Component\HttpKernel\HttpKernel->handle() /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.php:62 0.0204 2550816 5. Symfony\Component\HttpKernel\HttpKernel->handleRaw() /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:61 0.1007 7824400 6. call_user_func_array:{/opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:117}() /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:117 0.1007 7824736 7. Janus\ServiceRegistry\Bundle\RestApiBundle\Controller\ConnectionController->getConnectionAction() /opt/data/openconext/OpenConext-serviceregistry-5.1.4/simplesamlphp-1.12.0/modules/janus/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:117

lucasvanlierop commented 9 years ago

Fixed