search

janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.
Other
13 stars 8 forks source link

[REVIEW] Fix remove items layer in api metadata origin/develop #527

Closed lucasvanlierop closed 9 years ago

lucasvanlierop commented 9 years ago

Removed the metadata since it had no real value and resulted in incorrect output in the API, an array named items. The (dis)assembling logic was moved to separate tree builder/flattener classes. All refactored code was tested before the refactoring was done.

lucasvanlierop commented 9 years ago

@relaxnow please review

relaxnow commented 9 years ago

:+1: removed code, added tests. Borat says: Very Nice!

relaxnow commented 9 years ago

Could you take a look at the 'array of arrays' documentation in a small separate PR?

lucasvanlierop commented 9 years ago

Will pick that up later: https://github.com/janus-ssp/janus/issues/530, now continuing to work on the publish metadata issue