[REVIEW] csrf protection

janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.

Other

13 stars 8 forks source link

[REVIEW] csrf protection #539

Closed relaxnow closed 9 years ago

relaxnow commented 9 years ago

@lucasvanlierop could you review and merge if okay?

lucasvanlierop commented 9 years ago

Honest answer? Good work but so much has changed that's hard to review or test and if so much has to be changed I would rather see a complete form rewrite instead...

relaxnow commented 9 years ago

It's not that much honestly. I would much rather see a rewrite too, but that would take more time than I have in 2014. Hopefully when we start adding OIDC connections in 2015 we can take a fresh look at janus and the OpenConext Service Registry.

lucasvanlierop commented 9 years ago

Ok, we leave it to @DRvanR and friends ;-)

lucasvanlierop commented 9 years ago

I cannot merge this PR however due to a conflict

DRvanR commented 9 years ago

@lucasvanlierop heh, not sure if we're even gonna touch this ;)