search

janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.
Other
13 stars 8 forks source link

Update www/importentity.php #603

Closed tvdijen closed 7 years ago

tvdijen commented 7 years ago

[Wed Sep 21 15:35:30 2016] [error] [client 10.68.130.101] PHP Fatal error: Call to undefined method SimpleSAML_Session::getInstance() in /apps/janus/janus-1.22.0/www/importentity.php on line 15

I think this one wasn't fixed properly to support SSP 1.1.14

tvdijen commented 7 years ago

Yes, it is. He used an SimpleSAML_Auth_Simple object to replace the deprecated SimpleSAML_Session::getInstance(), but that object doesn't define the getValue/setValue methods used a bit further down in this file. I must admit I'm not entirely sure if my fix is right, but at least it works for me. I'll discuss the change with @mrvanes tomorrow when I see him.

tvdijen commented 7 years ago

After reading the deprecation notice of SimpleSAML_Session::getInstance() and this post by @jaimeperez, I really think @mrvanes has approached the whole sessionfix-patch the wrong way. Perhaps Jaime can comment on this.

tvdijen commented 7 years ago

@mrvanes and I agreed on a mix of both worlds.. This has been tested and works / fixes the build.