janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.
Other
13 stars 8 forks source link

General improvements #606

Closed tvdijen closed 8 years ago

tvdijen commented 8 years ago

This PR fixes some XHTML compliancy issues, a few uppercase keywords (PSR-2), some shorthand-tags and just a few minor readability improvements.

This takes the amount of errors (W3 validator) from 42 > 35. Most remaining errors are related to inline JS though, so a next iteration could be to move all JS / CSS to .js/.css files. If this is appreciated, I can make a PR for that too.

thijskh commented 8 years ago

As you might have noticed we're not putting much work into Janus this year. Perhaps next year when we may have more info e.g. on the future role of OpenID Connect.

tvdijen commented 8 years ago

Yeah, I think Martin mentioned it that this project is pretty much on hold.. That's fine, it does the job. I'll just send in Issues/PR's when I run into something.