search

janus-ssp / janus

Fully featured metadata registration administration module built on top of simpleSAMLphp.
Other
13 stars 8 forks source link

Produce valid PHP on application/simplesamlphp+text feeds #620

Closed jorgelzpz closed 7 years ago

jorgelzpz commented 7 years ago

A feed configured to use the provided application/simplesamlphp+text mime produces almost valid PHP code, but it requires some tweaking to be used.

This PR makes it actual PHP code by adding:

jorgelzpz commented 7 years ago

Any thoughts on this one?

thijskh commented 7 years ago

Hi Adobo. I think this depends a bit on what you expect. What is exported now, is an entry you can add to or paste into an existing saml20-(idp|sp)-remote.php file which already has an $metadata = array() in it. Adding a PHP start tag would create a similarly valid, but different file. So I'm not sure that either is better than the other.

jorgelzpz commented 7 years ago

Sure @thijskh , I should have explained myself better. My fault!

Current flatfile exportation format has some limitations. Using it requires you to add a $metadata= array( and ); wrapping the result, and perhaps a <?php opening tag if you are working on a clean *remote.php file.

By directly generating valid PHP code you can automate metadata download to SSP by just configuring a curl/wget command outputting to a saml20-*-remote.php file, letting you to skip some steps: preparing a common PHP starting code, appending the output from the feed and adding a closing bracket.

Hope it makes sense now.

thijskh commented 7 years ago

Yes, I understand now that the new format has a slight advantage over the old one. I'll merge it, thanks!