janusvm / .doom.d

My personal configuration for Doom Emacs
2 stars 0 forks source link

cycle-theme doesn't work on newer versions of Doom Emacs #3

Closed janusvm closed 2 years ago

janusvm commented 2 years ago

Running jsvm/cycle-theme (SPC t t) does not work consistently across versions;

On the latter version, I also get an error when trying to run describe-variable (SPC h v) on doom-theme after running jsvm/cycle-theme:

elisp-refs--read-all-buffer-forms: Unexpected error whilst reading ~/.emacs.d/core/core-ui.el position 229: (void-variable read-symbol-positions-list)

It's likely that the implementation of jsvm/cycle-theme messes up the doom-theme variable, as right now it works by hard setting the variable and calling doom/reload-theme. A better implementation would probably be to simply use load-theme directly.

janusvm commented 2 years ago

The void-variable error turned out to be due to read-symbol-positions-list being removed in Emacs. It can be fixed by defining the variable myself somewhere.