search

janusw / Camera.Maui

A CameraView Control for .NET Maui
MIT License
17 stars 3 forks source link

Snapshot result does not fit preview #5

Closed kossoj closed 4 months ago

kossoj commented 5 months ago

There is still an issue with snapshot results on Android. It looks like the line to fix it is commented out. See the original issue: https://github.com/hjam40/Camera.MAUI/issues/98

janusw commented 5 months ago

There is still an issue with snapshot results on Android. It looks like the line to fix it is commented out.

Which line are you talking about?

kossoj commented 5 months ago

A line has been commented out in TakeSnap method. line But I can just see that it is different from the proposal: bitmap = Bitmap.CreateBitmap(bitmap, (bitmap.Width - Width)/2, (bitmap.Height - Height) / 2, Width, Height);

aleksandervalle commented 5 months ago

https://github.com/hjam40/Camera.MAUI/pull/132

janusw commented 5 months ago

hjam40#132

I have cherry-picked this fix into my master branch now. The CI (GIthub Actions) automatically builds a nupkg that you can use, and I hope to tag another release soon.

janusw commented 4 months ago

Fixed with release 1.4.7: https://github.com/janusw/Camera.Maui/releases/tag/1.4.7