search

janvankampen / heldnodig-site

2 stars 5 forks source link

Convert zipcode to city #1

Open janvankampen opened 4 years ago

janvankampen commented 4 years ago

Due to time pressure, I've never implemented a feature to convert zipcodes to a city. The city field already exists in the data structure on Request and Hero (LocationCity), but I fill it manually on review.

I want to use a free service, or a static list to convert and fill it.

xvilo commented 4 years ago

Maybe it's nice to keep the postalcode, as this will pin someone down on a small scale. This could usefull in larger cities. We should either add this data directly from a source (google maps api) when submitting or run a cron that resolves this ever x minutes async.

xvilo commented 4 years ago

Poc with current master: https://github.com/janvankampen/heldnodig-site/pull/39/files

Either I can refactor based on @ferrydeboer's MR or he should refactor his, based on mine :)