janvarev / OneRingTranslator

Simple local REST web service to translate texts. Plugins. Automatic calculate BLEU/COMET metrics of translation quality.
MIT License
113 stars 12 forks source link

Dockerfile? #6

Open skyler14 opened 1 year ago

skyler14 commented 1 year ago

Any chance you might wrap this up to have a built in docker build file? It would make testing out and deploying this pretty standard and simple. For people who make plugins it'd be pretty trivial to just provide what needs to be appended to the dockerfile and build it again.

janvarev commented 1 year ago

May be, but later.

AbdelatifAitBara commented 1 year ago

Hi @skyler14,

You want to have a Dockerfile to build this project ? I'll create one and do a PR later if @janvarev accept ? Thank u.

zba commented 10 months ago

I tried to run it in docker, but you have hardcoded 127.0.0.1 as listen host, can you please make it optional @janvarev ? Fpr docker I need to listen 0.0.0.0

upd: worked around this using this code, bu I not like it :)

# change workdir to /OneRingTranslator
import os

# Change workdir to /OneRingTranslator
os.chdir("/OneRingTranslator")
from run_webapi import uvicorn
uvicorn.run("run_webapi:app", host="0.0.0.0", port=4990, log_level="info")
janvarev commented 10 months ago

@zba Ok, in plans.