janverschelde / PHCpack

The primary source code repository for PHCpack, a software package to solve polynomial systems with homotopy continuation methods.
http://www.phcpack.org
GNU General Public License v3.0
59 stars 21 forks source link

Python 3.8 install issue #32

Closed NathanDunfield closed 3 years ago

NathanDunfield commented 3 years ago

I prefer to manage my Python packages with pip, so in the past I have installed PHCpy3 via:

cd PHC_src/src/Objects
make -f makefile_unix phcpy2c3.so
cd ../Python/PHCpy3
python3 -m pip install .

This worked with Python 3.6, but with Python 3.8 (and very recent versions of pip, setuptools and wheel), the above is no longer copying phcpy2c3.so into site-packages/phcpy. Looking at the verbose output of pip, I see the garbled line:

copying phcpy/phcpy2c3.so -> build/bdist.linux-x86_64/wheel/sage/local/lib/python3.8/site-packages/phcpy

where site-packages is /sage/local/lib/python3.8/site-packages/. I believe this has to do with the use of get_python_lib in setup.py.

There is a simple fix which actually simplifies setup.py, I will create a pull-request for this shortly.