Advertise ADC protocol with ALPN

janvidar / uhub

A high performance ADC peer to peer message hub.

http://www.uhub.org

GNU General Public License v3.0

70 stars 28 forks source link

Closed dennwc closed 5 years ago

dennwc commented 5 years ago

Advertise ADC protocol with Application-Level Protocol Negotiation when serving TLS connections. See proposal for more details.

This will not affect existing clients. Regardless of the ALPN negotiation outcome, the hub will continue to speak ADC.

Because of this, we don't check the result of SSL_get0_alpn_selected, since we won't be able to switch protocols anyway.

Still, this will help clients to detect an exact protocol version used by uhub.

This change is

dennwc commented 5 years ago

Needs a few more changes.

dennwc commented 5 years ago

Should be good now, please take a look.

CI is disabled for some reason, but it passes on the fork.

tehnick commented 5 years ago

LGTM

dennwc commented 5 years ago

@janvidar Friendly ping.

janvidar commented 5 years ago

Merged - with minor fixup.