search

janwytze / stackftp

Stack webdav to ftp server
0 stars 2 forks source link

Improved user caching #38

Closed janwytze closed 7 years ago

janwytze commented 7 years ago

Redis is not used because the StackUser class is not serializable. We can't make it serializable because sardine can't be made serializable.

janwytze commented 7 years ago

I have no idea if it will cache exceptions. Because when we can't connect to stack and the exception would be saved the user can't login because the exception is cached, we have to test this.

janyksteenbeek commented 7 years ago

How does simple caching work / what can I compare it with? There's not a single way we can use Redis?

janwytze commented 7 years ago

@janyksteenbeek Single caching is just stored inside Java. So it is very easy to work with non-serializable objects. We can still use Redis for other things later.

Single caching can be compared with what we had before this PR.

Also we can't keep a HTTP connection alive in Redis, and that is the whole point of caching the user.

janyksteenbeek commented 7 years ago

Appreciate the clarification. Will put this through