search

janx / chardet2

Universal Encoding Detector
GNU Lesser General Public License v2.1
23 stars 9 forks source link

Adding support for ruby 2.0.0 #4

Closed fotanus closed 11 years ago

fotanus commented 11 years ago

This patch adds support for ruby 2.0.0.

The only thing that changed is that to create regexps with "odd" characters another parameter is needed, according to the docs

This parameters for Regexp#new are around since ruby 1.8.7, but there was no documentation. On ruby 2.0.0 they are now really needed, and so it is on documentation. So this patch is also retro-compatible.

Since there are no automated tests, it was simply evaluated by being successfully loaded.

If possible, release a new version of the gem with this changes, because I really need it.

fotanus commented 11 years ago

Hi,

Thanks to get the typo.

I tested on ruby 1.8.7, 19.3 and 2.0.0 and it seems that the /[\x80-\xFF]/n on the end works, and it is cleaner, so I agree it is a better alternative. I'll remove this pull request and issue other with this syntax.