search

janx / chardet2

Universal Encoding Detector
GNU Lesser General Public License v2.1
23 stars 9 forks source link

Merge with chardet or rename repo to chardet2 #9

Closed execat closed 11 years ago

execat commented 11 years ago

Hi,

The repo name is chardet, but the gemspec and the install instructions mention the name "chardet2".

If this can be resolved by merging this code with what originally was chardet, or the repo be renamed to chardet2, it would help solve the confusion.

If the issue is more complex than this or I am not understanding the whole issue, please let me know.

Thanks.

janx commented 11 years ago

I created this repo because the original gem stopped moving forward. I cannot push this modified version to rubygems.org as chardet because name conflicts, so I rename it to chardet2 here.

The repo's name should be chardet2, thanks for pointing that out.

execat commented 11 years ago

Is there no way of contacting the authors of the original Gem and try to merge things?

There are still gems like charlock_holmes that list chardet as dependency, when it should be chardet2 (because chardet doesn't even work in a bunch of conditions). You can't change every dependency from chardet to chardet2, but you can merge the changes and help chardet move forward while retaining the name.

janx commented 11 years ago

Dependencies in other gems is beyond of the scope here, it's their option to choose which one to use.

At this time, I just spent the minimal amount of time to keep it work on 1.9/2.0, I have no plan and time to push things forward. When I need to I guess I'd rather rewrite the whole gem by porting directly from mozilla's originally C++ source code.

Please feel free to fork this repo and do whatever you want - contact the original author, merge other forks, etc. :beers:

execat commented 11 years ago

Thanks for the prompt replies!