janxyz / custom-hot-corners

A GNOME Shell Extension for customizable hot corners.
GNU General Public License v3.0
43 stars 5 forks source link

Primary display should be Window 1 #5

Closed esplinr closed 1 year ago

esplinr commented 5 years ago

Environment:

Steps to reproduce:

  1. Open Gnome Settings -> Devices -> Displays
  2. Verify that the "Built-in display" is the primary display and marked with a "1"
  3. Open Gnome Tweaks -> Extensions -> Custom hot corners
  4. Setup the top left hot corner on Window 1 to "Toggle overview"
  5. Close the setup window and gnome tweaks

Expected behavior:

  1. When putting the mouse into the top left corner of the primary display, the overview should be shown

Observed behavior:

  1. When putting the mouse in the top left corner of the attached external display, the overview is shown

Notes:

janxyz commented 5 years ago

Thanks for the detailed report. Currently the extension identifies monitors by their position in the Main.layoutManager.monitors array. Although Gnome settings shows the primary display as number 1, the described behavior sounds like the secondary display takes the first place in this array if it is attached. You could verify this with Looking Glass by checking the value of Main.layoutManager.primaryIndex with the second display attached.

esplinr commented 5 years ago

That is the behavior I am seeing. As a result, the hot corner does not behave consistently whereas the approach taken by customcorner is more reliable.

WuerfelDev commented 4 years ago

Is it maybe possible to show the vendor and monitor size like its done in gnome-control-center? That would be less confusing

janxyz commented 4 years ago

Hi, I'll try to implement that when I find some time for it. Pull requests of course are also welcome.

mitar commented 4 years ago

This was completely confusing to me. I thought that the extension does not work.