jaonoctus / exchange

[WARNING: Under development] An Open Source Exchange, made with Laravel (PHP) and Vue (JS)
http://coin2sale.herokuapp.com/trading
MIT License
58 stars 48 forks source link

Database structure #6

Open jaonoctus opened 6 years ago

jaonoctus commented 6 years ago

screenshot from 2018-02-19 16-14-39

TODO

jaonoctus commented 6 years ago

@vjoao @ibrunotome

What about it, guys?

ibrunotome commented 6 years ago

Hi, I think the decimal fields can't be 8,2, because much of the orders will be a big fraction like 0,00724 for example. I suggest a 16,8 like the binance uses.

jaonoctus commented 6 years ago

@ibrunotome I totally agree!

I've updated this issue with a "TODO" section.

Thanks

vinyvicente commented 6 years ago

@jaonoctus, uses uuid in public reference (orders, by example), id integer is vulnerable, principally to inspect element, etc :)

vjoao commented 6 years ago

@vinyvicente Order information is already public. As UUIDs are 4 times larger than integers, this might reflect in storage problems in the future.

jaonoctus commented 6 years ago

@vinyvicente, I agree with @vjoao. But, for sensitive data, we can use hashids.