Beta Release Thread + Code Freeze Reminder

[japacible]

General thread: It would be good to give everyone an overall snapshot of how the beta phase is going.

I'm looking at the schedule and would love to hear how everyone thinks things are going. Any ETA of code drops, code reviews you think you'll need, or questions/troubles? Is anyone blocked by certain tasks?

Code Freeze is scheduled for Friday evening, 11.22, at midnight (or 11:59:59 pm, whatever you prefer). If you can't make that time for some reason, please tell us sooner rather than later.

Note: 11.22 is FallFest. @quanc and I are ACM officers, which means half of the afternoon and most of the evening is gone for us. If you need us to do anything ASAP, please grab us before 3pm! You should show up to FallFest for at least part of the time to relax.

[jbrodhacker]

I'm a bit blocked on #116 by #72 at the moment due to the decision that the front end would handle creation of the json and parsing of it. However, once that is checked in, I have a pretty good idea of the work that will need to be done and, hopefully, it won't take too long. I expect I'll be done with it by mid-afternoon/early evening (~5-6) tomorrow at the latest. There's also a bit of work I'll need to do for #120 and #117 as well, but that is also blocked until I have access to accept/decline and update review buttons :)

[jbrodhacker]

If I start getting nervous about the blocks though, I can always try stubbing out the front end work and try it from there.

[japacible]

Is there a partial front end to work with, or nothing pushed at the moment? Not sure if I'm looking at the right branch(es) if a central one for commissions exists.

[jbrodhacker]

There isn't any central branch for commissions. As far as I'm aware, there isn't too much of a front end to work with (at least, one that has our current design implementation in mind).

[jbrodhacker]

Just created a new branch ( wip-commissions ) for the commissions team to utilize as a main branch.

[kcorman]

I think we may have to complete the commission request template tomorrow. Like @jbrodhacker said earlier, @Bejoty got caught up on a major issue which blocked us. This was in part due to a poor design choice I made earlier about trying to parse forms on the client side. Hopefully we can finalize this before noon tomorrow. I'll be up early.

[japacible]

Thanks for the update! I just got home and will be catching up on messages and working all of tonight.

[japacible]

Where is everyone on their work? I know @kcorman @jbrodhacker and @quanc are working on their respective tasks; @acouch00 and @Bejoty, where are you with progress?

[japacible]

@jbrodhacker do you need me to do anything for commissions? I'm waiting for @kcorman's merge for messaging, so I have a bit of time for any tasks! I set aside all of today to work on the beta release.

[jbrodhacker]

Not at the moment, I am currently waiting for @kcorman as well to finish up massaging @Bejoty's code into being a bit more server-side friendly. I'll let you know if I come across anything though :)

[jbrodhacker]

I apologize for the embarrassing lack of the word "code" in my original post... I'm gonna go hide in a corner now....

[kcorman]

lol I actually read it as 'messaging', which is what I have been working on, until you mentioned it. :) Anyway I wanted to let you know that I did look into the code @Bejoty pushed yesterday to see if I could add a server side component for you to hook into. At this point I couldn't quite figure out how to make it post data since it doesn't seem to be a form yet. I'll still look into it more in about two hours, have to leave the house for a bit.

On Sat, Nov 23, 2013 at 3:27 PM, jbrodhacker notifications@github.comwrote:

Not at the moment, I am currently waiting for @kcormanhttps://github.com/kcormanas well to finish up massaging @Bejoty https://github.com/Bejoty into being a bit more server-side friendly. I'll let you know if I come across anything though :)

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/128#issuecomment-29144447 .

[japacible]

@kcorman If you're leaving now, do you want me to merge the ft_messaging_mailboxer branch to master?

[kcorman]

Yeah I'm actually doing that before leaving. =D

On Sat, Nov 23, 2013 at 3:35 PM, Jennifer Apacible <notifications@github.com

wrote:

@kcorman https://github.com/kcorman If you're leaving now, do you want me to merge the ft_messaging_mailboxer branch to master?

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/128#issuecomment-29144601 .

[japacible]

Oh ok, let me know when you're done! :)

[jbrodhacker]

Alright, sounds good :)

[kcorman]

K just pushed it.

On Sat, Nov 23, 2013 at 3:37 PM, jbrodhacker notifications@github.comwrote:

Alright, sounds good :)

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/128#issuecomment-29144655 .

[japacible]

Thanks!

[japacible]

@Bejoty @acouch00, are you working on anything? Haven't heard from you since yesterday.

We still have commissions to put together, and the deadline is EOD.

[japacible]

Okay, I'm checking up with people individually and I'm getting very conflicting stories on who is doing what. I've come to the conclusion that nobody from the commissions team took the task of actually creating scaffolding pages. (Or it might be @Bejoty, but I can't find him at all)

We have 5 hours left. Can someone please do this? I'm still dealing with the reader view on messages.

[Bejoty]

I'm coding the commission request JS on the metro, but that has its limits. I don't have a time estimate unfortunately, both because of my lack of Internet until I get home, and just the jankiness of JS. I'm planning to lose sleep over it though.

This is also why I was working during Fall Fest ;)

Oh, I just realized I forgot to trigger the form submit on the other page! Whoever gets to it first, it should in theory just require the

tag to have the attributes action="[ruby script page]" and method="post".

Also, the submit button needs a line of jquery code "type": "submit" instead of "type": "button".

Hopefully that's enough to get it correctly submitting.

[quanc]

I was under the impression that @Bejoty would be doing the scaffolding pages from his mocks and demo, but I can't find them anywhere. I'd be willing to try to do them if nobody else is doing them, since our deadline is coming up.

I've been working on bringing the site UI up to spec for the homepage, log in/sign up page, profile pages, settings page, and commission request page. It would be great if we could all clarify what we're doing, since it seems like there has been lot of miscommunication.

[acouch00]

I did some research into payments, in 119. As it is, I am working on a paper that is due soon. I'm truly sorry, but I simply cannot help with the scaffolding right now.

[Bejoty]

Oh, new message on this while I was typing (sorry on my phone). If I recall, the pages necessary to get the commissions beta finished are the settings page (needs server scripting), request page (only the static view is currently in the repo, working on the dynamic page now), and the artist review page (currently only an accept/decline; I don't think this exists yet, but it's the least work of the three if someone wants to claim now).

We decided to skip the revision stage for now, as well as a progress page, and obviously payments was pushed to the side as well. I imagine the "in progress" will just be a dashboard status, with a button next to it on the artist dashboard to mark as complete.

[quanc]

@Bejoty This is due in about 5 hours. Can you push what you have?

Also, when you mentioned that the settings page, request page, and artist review page are necessary to get the commissions beta finished, did you mean that the scaffolding is already done for them?

[japacible]

@Bejoty if you're working on the dynamic page, can you push everything else and give us an ETA for that dynamic page? @quanc is completely blocked at the moment.

[japacible]

Push to the main commissions branch. Do NOT push to master. This is something we need to verify functionality and then merge.

[Bejoty]

Three things:

1) I'm not going to be near Internet for at least another hour, but I'd be happy to push once I am.

2) Upon thinking about it further, I think the comset JS page does set up a POST submit, just not in the normal form nature. It should come to the same ends, but I wasn't able to test it. The above fix is an alternative that should really just do the same thing. The page certainly posts something already.

3) I was more focused on functionality than scaffolding, but if it's to get mocks up by midnight, I can switch over to making static views when I get home.

[japacible]

I was more focused on functionality than scaffolding, but if it's to get mocks up by midnight, I can switch over to making static views when I get home.

The beta release is due tonight. We don't need mocks. We need working features.

[quanc]

@Bejoty We need to be done way before 11:45pm because we have to do documentation as well. What scaffolding is currently done and what are the pages named? It wasn't originally my job to do scaffolding, but it seems like I'll be doing it.

[kcorman]

Just wanted to chime in that I might have something coming for this, but have to see if I can fix up an error before making any promises.

On Sat, Nov 23, 2013 at 7:05 PM, Christina Quan notifications@github.comwrote:

@Bejoty https://github.com/Bejoty We need to be done way before 11:45pm because we have to do documentation as well. What scaffolding is currently done and what are the pages named? It wasn't originally my job to do scaffolding, but it seems like I'll be doing it.

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/128#issuecomment-29147788 .

[quanc]

I've been looking through the stuff in wip-commissions myself. I found progress.html.erb, comset.css, com-settings.html.erb, and comset.html.erb. None of these .html.erb pages look anything like any of the other .html.erb pages we have (aside from the filenames). I am also unsure of what comset.css is; we currently have all our styles in style.css. Have you gotten these .html.erb files to show up on http://0.0.0.0:3000/? I can't get them to work. Could you please explain so I can finish up commissions before the deadline?

[japacible]

@kcorman, what are you referring to?

[kcorman]

@japacible Can you get on gmail chat or something? I'll explain what I'm up to. It's somewhat verbose to describe here.

On Sat, Nov 23, 2013 at 7:32 PM, Jennifer Apacible <notifications@github.com

wrote:

@kcorman https://github.com/kcorman, what are you referring to?

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/128#issuecomment-29148108 .

[japacible]

@kcorman I'm online. japacible@gmail if you need to add me

[jbrodhacker]

An update as to what's going on from either @kcorman or @japacible about connecting server side and front end commissions would be appreciated when possible. There's not a whole lot more playing around with models and controllers I can do at the moment.

A location status update would be appreciated as well from @Bejoty.

[japacible]

Hey, I'm finishing up some bug bashing and somewhat aesthetic fixes on messages so we have at least one complete feature for the beta release.

@kcorman is currently working on commissions, but we only touched base briefly over chat. He'll be able to give you a better idea of the status of commissions. Sorry I don't have more info on this!

[japacible]

Augh, second mis-click in the same evening.

[jbrodhacker]

Alright, thank you.

[jbrodhacker]

Just want to mention (to no one in particular, just as a heads up) that since we aren't going to have the review function in this iteration, there's no need to do any manipulations/adding/deleting/storing/retrieving of data in the commission requests table. The information that the commissions table stores should suffice.

[kcorman]

Hi Julie! I'm totally at my wits end. What I've managed to come up with is an almost-working commissions request template thing. Basically I was able to take austin's front end form and make it post to a controller which parses the data into a JSON. But for some reason, when I try to save this JSON into the User's json field it silently fails (ie their json does not get updated). I'm about to call it quits for tonight though, as my productivity is dropping rapidly. If it helps at all, User with email: eddy@gmail.com and password: secret has a valid CRT in its json field.

On Sat, Nov 23, 2013 at 8:47 PM, jbrodhacker notifications@github.comwrote:

Just want to mention (to no one in particular, just as a heads up) that since we aren't going to have the review function in this iteration, there's no need to do any manipulations/adding/deleting/storing/retrieving of data in the commission requests table. The information that the commissions table stores should suffice.

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/128#issuecomment-29148921 .

[japacible]

I'm calling it good for messages for the beta release. I'm going to write up documentation for it now.

[Bejoty]

Okay, Com Request page is mostly function on the data submission side. I'll push to the wip branch in a sec, but here's a preview:

http://bejoty.com/test/comreq/

[jbrodhacker]

@kcorman Hey :) If you could push all that you have, I can pick up where you left off and see if I can figure it out. I just want to say I really appreciate any and all of the work that you've done for the commissions team when it wasn't technically your responsibility. Thank you!

[Bejoty]

I'm not positive if the code for the POST submit is correct, and I'll have to search for the right syntax elsewhere because of all nights, the jQuery site is down.

I also tossed paging to the side, since it looks just fine having all the steps on one page.

[japacible]

I'm drafting @quanc to help me on documentation. We'll be monitoring email/issues if you need us for anything!

[kcorman]

Here's my branch. wip-commissions-kcorman Bug reproduction: log into account eddy@gmail.com, pw: secret navigate to /edit_template. Click on default_category, change some field values, click submit. You'll notice that there's a very long alert that demonstrates the changed JSON. But if you look at what's stored in the user (via using rails console), it will still be the old json.

You can check out the controller code in controllers/commission_request_templates.rb, method: update

On Sat, Nov 23, 2013 at 9:13 PM, Jennifer Apacible <notifications@github.com

wrote:

I'm drafting @quanc https://github.com/quanc to help me on documentation. We'll be monitoring email/issues if you need us for anything!

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/128#issuecomment-29149185 .

[japacible]

@Bejoty Can you develop against the repo in the future? That way we minimize the possibilities of any unexpected issues coming up. It checks whether gems and other libraries used are compatible and actually work with the current set up. It also allows other members see your progress and work on it in parallel.

I won't have time to code review any of your work since it's so late.

[jbrodhacker]

@kcorman Great! Thanks again :)

[Bejoty]

Of course. This time I had written all of that without any internet access though, so I couldn't have kept the repo up to date. I only put it on my site to see if the POST was working, but I haven't found a good way to tell yet.