Commissioners Cannot View Their Sent Commissions

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.

http://commissionme.herokuapp.com/

4 stars 3 forks source link

Commissioners Cannot View Their Sent Commissions #183

Closed acouch00 closed 10 years ago

acouch00 commented 10 years ago

Expected : Any user should be able to see the commissions that they have received as well as the commission requests that they have sent out.

Actual : Only commissions received are view-able.

Reproduction Steps :

Send a commission request.
Click on "My Commissions" on your public profile page.
Notice that the commission request that you sent doesn't show up here. What shows up here are the commissions that you have received.

(Feel free to close if duplicate!)

jbrodhacker commented 10 years ago

This will simply require a (preferably front end, but I think at this point anyone on the team could do it) dev to add into the requests.html.erb view under commissions something quite similar to what was done for the commissions received, but instead of iterating over @user.received_commissions, they'll want to iterate @user.requested_commissions.

jbrodhacker commented 10 years ago

I'm just not quite sure if this page that was simply meant to be a hack page because we were beyond short for time is the end-goal of viewing lists of commissions or not.

acouch00 commented 10 years ago

@Bejoty -- I hope you don't mind, but I'd like to go ahead and pick this up!

@jbrodhacker -- I think this was a hack-page, but it is definitely something that we want to have in the end. Thanks for the fix, by the way!

I'll let one of the front - enders pick up the task of making it more appealing. : )

japacible commented 10 years ago

@acouch00 if you're picking up this issue, are you still doing the payments prototype? Are you going to have time to do both by EOD today?

acouch00 commented 10 years ago

In master, ab75315ef978acab4172130521ce401d6f04fc73.

acouch00 commented 10 years ago

I want to make sure that we are all on the same page in terms of what I've proposed for payments. It would be great if we could all discuss this further either on the issue or in person.

The major components that need to be done for payments are the "Pay Now" button on the Commissioner's end and the "Payment Received" button on the Artist's end. This is slightly different from what we were talking about in this issue.