search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Implement Art Uploads #199

Closed japacible closed 10 years ago

japacible commented 10 years ago

At the end of a commission cycle, the artist should be able to upload the art. It should then be able to be pulled onto the artist profile, as well as the landing page.

@jbrodhacker / @kcorman shared task Est; 24h

Bejoty commented 10 years ago

Art uploads are also needed (at least with the current implementation) for the commission settings page for step example thumbnails. Is someone planning on or currently developing this? I don't see any other related issues open.

quanc commented 10 years ago

How is the status on this?

jbrodhacker commented 10 years ago

I'm having a hard time coming up with a solution of how best to transfer the data between the front end and the server side (in both directions) without the json getting over cluttered and keeping our images database table clean.

jbrodhacker commented 10 years ago

And I have yet to be able to try out actually getting the data into the database yet.

kcorman commented 10 years ago

Yeah this is a fairly difficult design problem. As far as the technical aspect goes, we could easily implement logic on the commission_request_templates controller that handles the preview option (or whatever its called) differently (ie rather than storing it in a JSON, puts it in a different table and stores the foreign id in the json). Of course we would have to be mindful of this when retrieving it too, as you said.

On Fri, Dec 6, 2013 at 3:58 PM, jbrodhacker notifications@github.comwrote:

And I have yet to be able to try out actually getting the data into the database yet.

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/199#issuecomment-30040354 .

jbrodhacker commented 10 years ago

Previewing doesn't even seem to be functional from what I saw when I was playing around with this. I was working on setting it up for the second option you mentioned - puts the image in a different table and stores the foreign id in the json - but I would then have to supply all the necessary images in the controller (as rails doesn't seem to like taking the param I give it in a function similar to the authenticity token function) and perform some sort of check to see what all has changed, and it gets even more hairy because of the ability to add and remove options...

jbrodhacker commented 10 years ago

And the gems that do this sort of thing for us assume that we're storing the images on S3, not a heroku database.

kcorman commented 10 years ago

oops my bad, I thought we were talking about thumbnails for the templates. Yeah for art uploads I was thinking we could still require people to host them somewhere besides our server because they could be high res.

On Fri, Dec 6, 2013 at 4:33 PM, jbrodhacker notifications@github.comwrote:

And the gems that do this sort of thing for us assume that we're storing the images on S3, not a heroku database.

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/199#issuecomment-30042024 .

jbrodhacker commented 10 years ago

I was talking about both really... the preview on the commissions settings isn't updating

jbrodhacker commented 10 years ago

So... considering the amount of time vs. the amount of progress on this issue (plus the likelihood of issues with heroku even if we did get this right running locally), do we simply want to let the artist post a link or something for the commissioner to download the piece from?

kcorman commented 10 years ago

I am totally in favor of this. I don't think we should mess around with this so late. I'd say do it that way and if it's really important to anyone to do it the other way we can let them figure it out. :)

On Fri, Dec 6, 2013 at 5:38 PM, jbrodhacker notifications@github.comwrote:

So... considering the amount of time vs. the amount of progress on this issue (plus the likelihood of issues with heroku even if we did get this right running locally), do we simply want to let the artist post a link or something for the commissioner to download the piece from?

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/199#issuecomment-30044230 .

quanc commented 10 years ago

I agree

jbrodhacker commented 10 years ago

Glad we're in accordance with this :) Closing as won't fix.

Bejoty commented 10 years ago

Hmmmmmm, I suppose that works. This release is going to be bare bones for the most part anyway. Just enough for a fully functioning system. At least at the moment there are probably more important things.

Edit: Oh wow, GitHub stopped updating this page for me. Definitely closed. ;)