search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Code review for popover #200

Closed acouch00 closed 10 years ago

acouch00 commented 10 years ago

SHA : 683a742603f48ddac521ffe55eab86177aff7417

Supplemental resource : Issue 187

My comments : The popover isn't great; I'll freely admit it, but it meets the specs that I received (more or less).

It would be great if the reviewer(s) could address the following concerns I had :

Also, just to put it out there, it's not super intuitive that hovering over the badge will display the popover. I would like to leave this aspect to someone who might have a better idea of how we might change the UI to improve the discoverability of this feature.

Thanks in advance!

japacible commented 10 years ago

Taking a look at this. Next time, please put the code review on a separate branch. The code review system exists for large changes before merging into master.

japacible commented 10 years ago

Added some comments! I know that some of the stuff wasn't spec'd out, I was commenting as I went along. :) Thanks for doing this!

acouch00 commented 10 years ago

16218682111a5bee82542d18ca100ea755521086 is the latest commit on this.

japacible commented 10 years ago

Commented.