search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Homepage Images Code Review #202

Closed quanc closed 11 years ago

quanc commented 11 years ago

Could someone take a look at my homepageimages branch to make sure the images (and test blocks) show up and tile correctly when the window is resized? It works on my computer but I'm not sure about everyone else's.

If someone could also do a code review, that would be great. My latest commit is here: 535a99f84b16423b46ca29799fafd1a8dd809a54

japacible commented 11 years ago

I'll take a look in a bit.

japacible commented 11 years ago

Minor comments, otherwise looks good.

I'm on Ubuntu/Firefox/Chrome, by the way. What OS/Browser are you on?

quanc commented 11 years ago

Updated my code here: 3a4d9b329bed4cc4a67bed4a79111274979bd54c

I'm on osx/chrome. It also seems to work on osx/safari.

japacible commented 11 years ago

Is anyone on Windows who can do a quick test? @kcorman, perhaps?

quanc commented 11 years ago

@acouch00 could you test this since you're on windows?

quanc commented 11 years ago

or @jbrodhacker could you take a quick look?

jbrodhacker commented 11 years ago

Unfortunately I'm not developing on Windows, I'm sorry.

japacible commented 11 years ago

@Bejoty is using windows, but I'm not sure when he'll have internet again.

quanc commented 11 years ago

Can I just merge this? I need to merge it before I can make progress on the navbar, so I'm sort of blocked.

japacible commented 11 years ago

Sure, just file a task to check browser compatibility. Otherwise, ship it!

quanc commented 11 years ago

Merged this here: 1d8cd743d371d7df6bb36de2fcb0ad7b0e81553d