Code review for: Commission request template added to new users

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.

http://commissionme.herokuapp.com/

4 stars 3 forks source link

Code review for: Commission request template added to new users #203

Closed kcorman closed 10 years ago

kcorman commented 10 years ago

26ff022

See commit message for details.

I've assigned @jbrodhacker but I'm quite confident in this code change so if anyone wants to give me a go-ahead I will merge this into master.

jbrodhacker commented 10 years ago

Other than some concern about Heroku and paths, it looks good to me :)

kcorman commented 10 years ago

Thanks! I agree about the concern with Heroku and paths. That's preciesly why I added error checking-- so that it won't break and it will log if we get issues with that. :)

Merged. Not going to post the most up-to-date hash because I screwed up the order and the dif looks funny again (I accidentally developed on my local master instead of a seperate branch, so I had to 'merge' with the remote master before pushing) This is what actually changed (what I posted earlier) 2eefc30b