japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Browser / OS checks for popover #206

Closed acouch00 closed 10 years ago

acouch00 commented 10 years ago

The popover -- Open it by clicking on the "View Commissions Stats" button on a given user's profile page. A popover opens up to the right of the button displaying a current summary of the states of all of commissions that the Artist has received.

The issue -- We're noticing that the contents of the popover render differently across operating systems and browsers.

In particular, "New Request 0" has been witnessed as being rendered as "New Requests 0." Observe the new line in place of the space.

The goal -- We need to figure out the reason for this inconsistency and fix this issue.

Related files --

-> app/views/users/show.html.erb
-> assets/javascripts/commissions-profile.js
japacible commented 10 years ago

pinging @quanc to see what she sees on osx.

quanc commented 10 years ago

Is this on master? Nothing seems to happen when I click "View Commission Stats" on master.

acouch00 commented 10 years ago

Due to some changes unknown to me, this functionality returns only after the user hits refresh. The popover only shows up after you've hit refresh and tried clicking on the "View Commission Stats" button again.

japacible commented 10 years ago

fileatask

So the steps are:

  1. Go to profile page
  2. Hit refresh
  3. Click button

Do you see any js errors? I'm not on a machine set up to run locally, so I can't check.

quanc commented 10 years ago

Thanks for letting me know. It looks like "New Request 0" is being rendered on one line for me:

screen shot 2013-12-02 at 4 30 26 pm

acouch00 commented 10 years ago

Thanks, @quanc.

@japacible -- I'm seeing this error in multiple instances, not just with the Popover. For example, on viewing a commission request, sometimes the data doesn't populate until you hit refresh.

quanc commented 10 years ago

It looks like we already opened an issue for the problem with content missing. Closing this.