search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Code review for javascript assets to partials #211

Closed kcorman closed 10 years ago

kcorman commented 10 years ago

As mentioned in #205 I deleted our javascript assets and moved them into partials which get embedded in each page. This change was necessary because I cannot for the life of me figure out how to get page-specific javascript assets to work on heroku, but rendering partials works.

(First commit) 62d8ab6c3

(Second commit because I forgot a file in first one) 1488d14

jbrodhacker commented 10 years ago

Looks good to me as long as that particular page still works with the functions defined together :)

kcorman commented 10 years ago

Thanks for checking it. I just merged it into master.

If anyone wants to help test to make sure stuff still works, that would be awesome. I did a little bit but not extensively.