search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Code Review for commission template category overwrite fix #218

Closed kcorman closed 11 years ago

kcorman commented 11 years ago

a1ad07822

This is fix to issue #180

Assigning @jbrodhacker but if anyone else comfortable enough with rails wants to confirm that's fine too.

@Bejoty If you see this soon enough, could you confirm the change to the javascript file? It should be benign but I'd love to have someone double check.

Updating your template will no longer change the name to default category and overwrite all categories. Also, if the client side is updated to allow new categories, this should support it with no server-side changes.

jbrodhacker commented 11 years ago

@kcorman Once the two comments I made on the commit are resolved, you have the go ahead from my end :)

kcorman commented 11 years ago

Thanks for the comments, Julie! And thank you Christina for offering insight about the colors. I wasn't sure which did which.

I have updated this and pushed to master (skipped second code review because I didn't think it would be necessary) e76ede9

Bejoty commented 11 years ago

Once @jbrodhacker gets the most recent dev interation merged (and def ask about the diffs if things get weird; THAT SAID, the dev branch's newer functionality trumps much of master's newer design and aesthetic changes), I'll go back through and fix any JS stuff that might have broke. In the meantime, I'm hands-off the Commissions Settings page.

That sentence got both syntactically and grammatically complicated quickly.

kcorman commented 11 years ago

Closing this. It was completed and now we're moving on to #225