japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Price in Commission JSON #221

Closed jbrodhacker closed 10 years ago

jbrodhacker commented 10 years ago

Change the commissions controller to accumulate price in the json so that payments has access to it via a single call of @commission.commission_current["price"]. This will also be helpful for when a commission is being reviewed such that the artist can adjust the price during the review process.

jbrodhacker commented 10 years ago

Finished in 57a02a7 on wip-commissions branch :)

@acouch00 Do you think you can migrate your payments onto a wip-commissions based branch or do you want me to create a separate commit for master?

acouch00 commented 10 years ago

Awesome! Thank you! Could you create a separate commit for me on master? I'll try to get to committing payments to master tonight.

jbrodhacker commented 10 years ago

On it :)

jbrodhacker commented 10 years ago

8513d43 contains the version for master :)

jbrodhacker commented 10 years ago

Note that this only works for commissions that you create now; older commissions will not have the total "price" in the json.

acouch00 commented 10 years ago

Thanks very much! I'll be committing payments to master now! :)

jbrodhacker commented 10 years ago

You're welcome :)

acouch00 commented 10 years ago

Thanks again -- it works beautifully now!

Payments in master : ee4e167bdc49be78de3545b9480eac7e0ea4b845.