Current State of Commissions

[jbrodhacker]

Here is the state of commissions as far as I'm aware:

• Commission Settings: Done, not touching it anymore
• Commission Requests: Done
• Commission Reviews: Accept, Decline, and First Revise buttons functional; still need:
  • Ability to submit revisions back and forth from artist and commissioner
  • Display of revision history
• Commission Accepted: Need to add buttons for commissioner to pay, artist to state that commissioner paid
• Commission Progress: Scaffolding just completed by @Bejoty at time of writing this, need to hook up to server side
• Commission Completion: Blocked by Progress page.

[jbrodhacker]

For @japacible.

[japacible]

Thank you, this is very helpful. :)

[jbrodhacker]

You're welcome :)

[jbrodhacker]

Quick update on this before I go to bed:

• Commission Revisions: basically done, just needs a bit of style changes on some things
• Commission Accepted:
  • Artist button exists (thanks to @acouch00 on the master branch!)
  • Need to sort out route issue for paypal button on commission review page
• Commission Progress:
  • Linked up to the commission flow
  • Need to have finish button for artist
  • Other functionality?
• Commission Completion: essentially done when everything else is.

[japacible]

Thanks for the update! Does this include pulling completed-commission images to the profile and landing pages, or is that a separate task?

[jbrodhacker]

Well... in #199 we decided that image uploads were too much work and whatnot... but...

2b8201c Artists can now upload an image, press the complete button, and on the review page the image will render for both artist and commissioner only :)

[japacible]

Ah, gotcha. What are we going to put in place of those, then? It'll basically be empty pages.

[jbrodhacker]

dc4624b Fixed the paypal button on the commissioner's review page.

We can still grab those images from the database, though they won't have the artist id attached to them... but I can add in the artist id if you want.

[japacible]

That would be wonderful if you can :)

[jbrodhacker]

It's just that on the commission page the image shouldn't be accessible to anyone but the artist and commissioner (assuming that we even allow other people to look at commissions they aren't part of).

Alright :)

[jbrodhacker]

Added artist id to images 2bd6058

[Bejoty]

@jbrodhacker After artist review, the customer pager view is failing to load the new information. Is that still waiting on an edit from me, or did something break? (I'm possibly using too old of a registered user)

[jbrodhacker]

Checking now.

[jbrodhacker]

Should be fixed as of 5496f9c (git diffs for this commit and the parent are so weird because I accidentally pulled from wip-commissions by habit so I tried copy pasting into a different cloned repo, but forgot that emacs doesn't delete selected text when you paste).

[jbrodhacker]

It was simply that the new specification panel code was still there for the artist, but wasn't in the commissioner part of the file.

[Bejoty]

Is wip-commissions updated with that then? I'm looking at a commission request I made yesterday, so it may not have the right stuff in the object. It's also a commission between users 66 and 3, so perhaps it's a legacy issue.

[jbrodhacker]

I pushed it straight to master, so no.

[Bejoty]

Ah, are we just working on master atm?

[jbrodhacker]

Depends on the changes being made - if it's a quick and easy fix, then master is fine at this point assuming you test everything beforehand... If you're adding new functionality (as @kcorman is doing) then you should be working on a branch.

[Bejoty]

Cool, glad we're still doing that. So what was the next thing needed on my end to finish up the feature?

[jbrodhacker]

In theory, everything is working at the basic level. It's possible to get through the entire commissions flow now. #234 would be the next thing to look at.

[Bejoty]

Okay, my bug must be a legacy thing then, working with old users.

A commission from user 3 (customer) to 66 (artist) breaks down at the revision stage. Attempting to send the revision gives me this: http://i.imgur.com/MzCISLx.png

I'm only using those users because they're the only ones I know passwords for and I didn't feel like registering another dummy user yet.

[Bejoty]

Still getting the above error on master when trying to revise. Registered a new user for it too.

[quanc]

Looks like we're done with this and Julie fixed the revision error. Closing this.