search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Login Broken #236

Closed jbrodhacker closed 10 years ago

jbrodhacker commented 10 years ago

I cannot log in on wip-commissions.

Bejoty commented 10 years ago

Do you think it was the merge?

jbrodhacker commented 10 years ago

Neither by logging into a current user or by signing up. This is likely due to something that was merged into wip-commissions from master.

jbrodhacker commented 10 years ago

Anyone else encountering this?

quanc commented 10 years ago

I can't log in or sign up either.

acouch00 commented 10 years ago

As you said, it appears to be broken on master too.

Bejoty commented 10 years ago

No errors, just redirects to the front page without logging in. Same with yours?

quanc commented 10 years ago

That's what's happening with me.

acouch00 commented 10 years ago

Yes, exactly.

jbrodhacker commented 10 years ago

Okay, thanks guys.

japacible commented 10 years ago

This is because of the password check (6char). I'm guessing none of your passwords are 6char or greater in length.

I commented out the line in master from app/models/user.rb for a quick fix.

japacible commented 10 years ago

Forgot our old users had <6char passwords since I always use "asdfasdf" as my password. :( Sorry for any inconvenience!

acouch00 commented 10 years ago

Oh, wow. You've got to admit, this is / was pretty funny. Resolving this issue put us all into a huge panic.

Thanks, Jennifer.

jbrodhacker commented 10 years ago

Quite alright, isn't there a command for something like "on create" and "on edit" that can be used?

jbrodhacker commented 10 years ago

Kinda weird though, I've been using secret as a password which is 6 characters.

jbrodhacker commented 10 years ago

Which was initially why I had ruled that out as a suspect.

Bejoty commented 10 years ago

Hahaha, yup my test account password of choice is 3 letters.

acouch00 commented 10 years ago

Is it zero based counting?

jbrodhacker commented 10 years ago

ec1f2de added the fix for wip-commissions, with the :on => create syntax

jbrodhacker commented 10 years ago

If someone can make sure the validation occurs on edit as well in wip-commissions, I would appreciate it.

jbrodhacker commented 10 years ago

@acouch00 you'd think it wouldn't be because it's talking about a length and a minimum...

acouch00 commented 10 years ago

@jbrodhacker -- Thanks. Yeah, I saw "minimum," but I've learned never to trust those sorts of quantifiers. They don't often mesh well with how English is spoken sometimes.

japacible commented 10 years ago

Closing this. Reopened password length enforcement #185.