search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Commission flips back to Accepted after completion #239

Closed kcorman closed 10 years ago

kcorman commented 10 years ago

I noticed that once an artist hits complete on a commission, the artist can then go and press accept or decline. Clicking accept causes the commission to go back into the "Accepted" state, and thus begins another cycle.

I'm not sure if this is supposed to be working, but I thought I'd point it out. I'm going to try and help get things to a working state for the demo tomorrow.

jbrodhacker commented 10 years ago

Hopefully should be fixed with 8f55a4b. A chunk of code from master survived the merge that wasn't supposed to was all =P

jbrodhacker commented 10 years ago

Sorry if you were working on it and had to throw away code for it; review.html.erb has a lot of confusing logic and is pretty messy so I figured it might be better if I do it. I can add comments to it if that would be helpful.

kcorman commented 10 years ago

ooh okay! No worries. I was probably a little too quick when I fixed the conflicts!

jbrodhacker commented 10 years ago

Totally fine :)

japacible commented 10 years ago

@kcorman @jbrodhacker is this resolved? (from the earlier comments, it seems like it, but wanted to make sure)

jbrodhacker commented 10 years ago

The commit fixed it for me, so it should be resolved.

japacible commented 10 years ago

Thanks!