japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Commission revisions functionality #247

Open kcorman opened 10 years ago

kcorman commented 10 years ago

Hi guys,

I merged wip-commissions, master, my thumbnails branch, and the art upload branch. The only issue is that for commission revisions, the commissioner doesn't seem to be able to do anything.

Commissioner requests commission Artist requests revision -- Commissioner cannot really do anything here (just sees revision request but cannot change anything)

Is this intended functionality?

quanc commented 10 years ago

That's what I saw last night as well. I assumed that's intended functionality.

kcorman commented 10 years ago

Okay =) Just making sure.

On Mon, Dec 9, 2013 at 7:14 AM, Christina Quan notifications@github.comwrote:

That's what I saw last night as well. I assume that's intended functionality.

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/247#issuecomment-30139505 .

kcorman commented 10 years ago

Unrelated:

I'm about to head to school now, should be there in about an hour. You guys can play around with heroku to see if there's anything we need to avoid but it should be good. The only issue I noticed was that the commission stats stopped working again despite the fix that fixed it before being in place =/ but it's a minor issue.

On Mon, Dec 9, 2013 at 7:16 AM, Kenny Corman kennywcorman@gmail.com wrote:

Okay =) Just making sure.

On Mon, Dec 9, 2013 at 7:14 AM, Christina Quan notifications@github.comwrote:

That's what I saw last night as well. I assume that's intended functionality.

— Reply to this email directly or view it on GitHubhttps://github.com/japacible/commission-me/issues/247#issuecomment-30139505 .

japacible commented 10 years ago

fileatask (they look for issue tracking for anything that doesn't work) and we'll just not show commission stats during the demo ;)

jbrodhacker commented 10 years ago

This is not intended functionality and breaks the commissions flow. You can note that for the commissions that you tested with this, the state was not changed from NewRevision. The fix is here 2fc3b67